Beefier command queue recovery #6221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the controller is being reset, then the CQE needs to be reset as well. For removable cards, CQHCI_SSC1 must specify a polling mode (CBC=0) otherwise it's possible that the controller stops emitting periodic CMD13s on card removal, without raising an error status interrupt. Signed-off-by: Jonathan Bell <[email protected]>
Recovery claims the MMC card so the card-detect work gets significantly delayed - leading to lots of error recovery loops that can never do anything but fail. Explicitly detect the card after CQE has halted and bail if it's not there. Also ratelimit a not-very-descriptive warning - one occurrence in dmesg is enough to signal that something is amiss. Signed-off-by: Jonathan Bell <[email protected]>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 18, 2024
kernel: configs: Enable BLK_DEV_RBD See: raspberrypi/linux#6226 kernel: Beefier command queue recovery See: raspberrypi/linux#6221 kernel: ax25: Fix refcount imbalance on inbound connections See: raspberrypi/linux#6213 kernel: Add SunFounder PiPower 3 dtoverlay See: raspberrypi/linux#6227 kernel: Follow pwm_apply_might_sleep() rename in gpio-pwm and ir-rx51 See: raspberrypi/linux#6223
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jun 18, 2024
kernel: configs: Enable BLK_DEV_RBD See: raspberrypi/linux#6226 kernel: Beefier command queue recovery See: raspberrypi/linux#6221 kernel: ax25: Fix refcount imbalance on inbound connections See: raspberrypi/linux#6213 kernel: Add SunFounder PiPower 3 dtoverlay See: raspberrypi/linux#6227 kernel: Follow pwm_apply_might_sleep() rename in gpio-pwm and ir-rx51 See: raspberrypi/linux#6223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to reliably terminate IO to cards that went away. Sometimes the removal check can take 10 seconds, but this doesn't seem to generate any more side effects in the block layer.