ASoC: add the HiFiBerry 8-channel ADC soundcard #6353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelwell
reviewed
Sep 13, 2024
| dummy-codec { | ||
| #sound-dai-cells = <0>; | ||
| compatible = "snd-soc-dummy"; | ||
| // num-channels = <8>; |
There was a problem hiding this comment.
Did you mean to leave this line commented out?
There was a problem hiding this comment.
Ooops! Forgotten to delete and checkpatch does not complain ;-) But yes, it is not necessary as it is ultimately set in the driver init. But I can fix it together with the 75 char issues.
There was a problem hiding this comment.
If you can do that soon I'll get it merged this afternoon before the next rpi-update build
Additions and changes for the 8 channel ADC card. This card uses only HW-controlled devices which allows the uses of the 'dummy-dai'. It will run only on a PI5 as it requires the designware I2S0 module. The necessary output lanes I2S0_DI[0..3] are claimed from within the DT overlay. Signed-off-by: j-schambacher <[email protected]>
Definitions for the 8 channel ADC card. The card uses only HW-controlled devices which allows the uses of the 'dummy-dai'. It will run only on a PI5 as it requires the designware I2S0 module. The necessary output lanes I2S0_DI[0..3] are claimed from within the DT overlay. Signed-off-by: j-schambacher <[email protected]>
|
Thanks! |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Sep 18, 2024
See: raspberrypi/linux#6371 kernel: drm: vc4: Fix interpolate bit for nearest neighbour filter See: raspberrypi/linux#6364 kernel: drm: panel: ili9881: Correct symmetry on enable/disable return codes See: raspberrypi/linux#6360 kernel: vc04_services: codec: Allocate the max number of buffers on the VPU See: raspberrypi/linux#6348 kernel: ASoC: add the HiFiBerry 8-channel ADC soundcard See: raspberrypi/linux#6353
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Sep 18, 2024
See: raspberrypi/linux#6371 kernel: drm: vc4: Fix interpolate bit for nearest neighbour filter See: raspberrypi/linux#6364 kernel: drm: panel: ili9881: Correct symmetry on enable/disable return codes See: raspberrypi/linux#6360 kernel: vc04_services: codec: Allocate the max number of buffers on the VPU See: raspberrypi/linux#6348 kernel: ASoC: add the HiFiBerry 8-channel ADC soundcard See: raspberrypi/linux#6353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions and changes for the new 8 channel ADC card for the Pi 5.
It's a HW controlled device, so we can use the snd-soc-dummy device
for the DAI declarations.