-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add support for TI ADS7828/ADS7830 I2C ADCs #6819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks largely fine to me. Two things:
|
Thank you :) Apologies for the third commit, that was fixing a mistake I made in the first commit as I couldn't revert back to it (my git command line skills are limited at best). And I'd be happy to add the extra config file, sure - thanks. Do you just need all of the config changes in a single commit? I could add a commit reverting my config changes, then add a fresh commit with everything fixed and including the additional config file. |
To merge the 1st and 3rd commits:
|
Note that there is a strict 80 character limit on lines in the README. |
970f45f
to
be67ca7
Compare
c9a1f7a
to
d46d3bc
Compare
This was very useful, thank you! |
50ca862
to
f89adcb
Compare
I've now fixed the line lengths in the README file, and we're down to the two required commits. |
kernel: Add driver for the Waveshare DSI-TOUCH series panels See: raspberrypi/linux#6566 kernel: Add support for TI ADS7828/ADS7830 I2C ADCs See: raspberrypi/linux#6819 kernel: Add RS485 mode support for UART2, UART3, UART4, and UART5 See: raspberrypi/linux#6820
kernel: Add driver for the Waveshare DSI-TOUCH series panels See: raspberrypi/linux#6566 kernel: Add support for TI ADS7828/ADS7830 I2C ADCs See: raspberrypi/linux#6819 kernel: Add RS485 mode support for UART2, UART3, UART4, and UART5 See: raspberrypi/linux#6820
This patch adds the TI ADS7828/ADS7830 I2C ADCs to the i2c-sensors overlay, and adds the appropriate hwmon driver as a module include in the default kernel configurations. I needed this for a project & it would be useful to have in-tree.
It also adds support for the hwmon driver "label" property - I haven't added this to the other drivers at this stage, as it is outside of the scope of this pull request, and it may only be supported by the hwmon drivers and not IIO drivers.
Tested and working OK on a CM4 with a pair of ADS7830 ADCs, overrides in /boot/firmware/config.txt as follows:
dtoverlay=i2c-sensor,ads7830,i2c_csi_dsi,addr=0x48,label="adc-1"
dtoverlay=i2c-sensor,ads7830,i2c_csi_dsi,addr=0x49,label="adc-2"