TAS5713: return error if initialisation fails #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing TAS5713 driver logs errors during initialisation, but does not return an error code. Therefore even if initialisation fails, the driver will still be loaded, but won't work. This patch fixes this. I2C communication error will now reported correctly by a non-zero return code.
popcornmix
added a commit
that referenced
this pull request
Jan 23, 2015
TAS5713: return error if initialisation fails
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 26, 2015
See: raspberrypi/linux#769 kernel: Add pps-gpio overlay See: Hexxeh/rpi-firmware#71 kernel: TAS5713: return error if initialisation fails See: raspberrypi/linux#765 kernel: I2C: Only register the I2C device for the current board revision kernel: config: Remove STRICT_DEVMEM firmware: arm_loader: Enable the standard I2C interface by default using DT
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jan 26, 2015
See: raspberrypi/linux#769 kernel: Add pps-gpio overlay See: #71 kernel: TAS5713: return error if initialisation fails See: raspberrypi/linux#765 kernel: I2C: Only register the I2C device for the current board revision kernel: config: Remove STRICT_DEVMEM firmware: arm_loader: Enable the standard I2C interface by default using DT
neuschaefer
pushed a commit
to neuschaefer/raspi-binary-firmware
that referenced
this pull request
Feb 27, 2017
See: raspberrypi/linux#769 kernel: Add pps-gpio overlay See: Hexxeh/rpi-firmware#71 kernel: TAS5713: return error if initialisation fails See: raspberrypi/linux#765 kernel: I2C: Only register the I2C device for the current board revision kernel: config: Remove STRICT_DEVMEM firmware: arm_loader: Enable the standard I2C interface by default using DT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing TAS5713 driver logs errors during initialisation, but does not return
an error code. Therefore even if initialisation fails, the driver will still be
loaded, but won't work. This patch fixes this. I2C communication error will now
reported correctly by a non-zero return code.