Wrong condition in picoboard/blinky

[hotovson]

there is wrong condition on lines

pico-examples/picoboard/blinky/blinky.c

Line 57 in 2fb08a0

if (*str >= 'A' && *str < 'Z') {

and

pico-examples/picoboard/blinky/blinky.c

Line 59 in 2fb08a0

} else if (*str >= 'a' && *str < 'z') {

must be
if (*str >= 'A' && *str <= 'Z') {
and
} else if (*str >= 'a' && *str <= 'z') {
respectively

[lurch]

Hah, just took me about 10 minutes to see what the difference was!! 😆 🔍
In the version at https://github.com/raspberrypi/pico-examples/blob/develop/picoboard/blinky/blinky.c it's using < 'z' but it should be <= 'z' - which we obviously didn't notice ourselves because the example "Hello world" string doesn't contain a z.
Thanks for spotting this, I'll submit a PR...

[lurch]

This can be closed now @kilograham

[lurch]

@kilograham Ahhhh, so this is why issues aren't being closed when the associated PR is merged:

Note: The special keywords in a pull request description are interpreted when the pull request targets the repository's default branch. However, if the PR's base is any other branch, then these keywords are ignored, no links are created and merging the PR has no effect on the issues.

Looks like there's a 3rd-party "action" to get around that, if this behaviour becomes too annoying https://github.com/marketplace/actions/closes-issues-related-to-a-merged-pull-request
(but I dunno the security implications of giving a 3rd-party addon access to secrets.GITHUB_TOKEN )