Skip to content

Misc cleanup #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 18, 2025
Merged

Misc cleanup #2569

merged 12 commits into from
Jul 18, 2025

Conversation

kilograham
Copy link
Contributor

No description provided.

@kilograham
miscellaneous cleanup:
5425035 
* cleanup some #ifdefs which were slightly hacky when RP2350 was added; use HAS_ flags in preference to PICO_RP2040/RP2350
* make some dependencies more explicit - i.e. compile if the user doesn't want to include certain libraries
* cleanup some directory A -> directory B relative path names in CMakeLists.txt to be SDK root -> directory B
@kilograham
oops; missing change
f4e5f90
@kilograham kilograham added this to the 2.1.2 milestone Jul 16, 2025
will-v-pi
will-v-pi reviewed Jul 17, 2025
View reviewed changes
will-v-pi
will-v-pi reviewed Jul 17, 2025
View reviewed changes
will-v-pi
will-v-pi reviewed Jul 17, 2025
View reviewed changes
lurch
lurch reviewed Jul 17, 2025
View reviewed changes
lurch
lurch reviewed Jul 17, 2025
View reviewed changes
lurch
lurch reviewed Jul 17, 2025
View reviewed changes
lurch
lurch reviewed Jul 17, 2025
View reviewed changes
@kilograham kilograham requested a review from will-v-pi July 17, 2025 14:28
lurch
lurch reviewed Jul 17, 2025
View reviewed changes
lurch
lurch reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@lurch lurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what all of these changes are actually doing, but they all seem broadly sensible 👍

will-v-pi
will-v-pi previously approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - with that extra indentation fix that I missed

@kilograham kilograham merged commit 4242010 into develop Jul 18, 2025
11 checks passed
@kilograham kilograham deleted the misc_cleanup branch July 18, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch lurch approved these changes

@will-v-pi will-v-pi will-v-pi approved these changes

@peterharperuk peterharperuk Awaiting requested review from peterharperuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kilograham @lurch @will-v-pi