Skip to content

add_custom_command uses wrong arguments #235

@kilograham

Description

@kilograham
Contributor

e.g.

    add_custom_command(TARGET xip_ram_perms
        COMMAND ${CMAKE_COMMAND} -E copy ${XIP_RAM_PERMS_ELF} ${CMAKE_BINARY_DIR}/xip_ram_perms.elf
        DEPENDS xip_ram_perms
    )

Newest CMake now complains about this:

  1. you must now specify POST_BUILD explicitly
  2. DEPENDS was always incorrect I guess

Activity

added this to the 2.1.2 milestone on May 27, 2025
will-v-pi

will-v-pi commented on May 28, 2025

@will-v-pi
Contributor

This is fixed in picotool in #207 - I think similar fixes are also needed in the SDK tools/CMakeLists.txt

kilograham

kilograham commented on May 28, 2025

@kilograham
ContributorAuthor

could you make a PR for SDK too

added a commit that references this issue on May 29, 2025
5c8b80c
added a commit that references this issue on May 29, 2025
0476839
added a commit that references this issue on May 30, 2025
6841d4d
will-v-pi

will-v-pi commented on May 30, 2025

@will-v-pi
Contributor

SDK PR merged into develop too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

    Participants

    @kilograham@will-v-pi

    Issue actions

      add_custom_command uses wrong arguments · Issue #235 · raspberrypi/picotool