Export _getTmpName for temporary file name creation #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export _getTmpName for temporary file name creation
Closed
|
I would love to merge it if you could provide some tests. Could you do them? |
|
Sure I can, but I actually did not change any of your base library code - |
|
Yes, but since it's exported the API should not be changed and therefore a test is needed. |
|
Done. |
|
We probably should bump the version after this. |
|
Thank you, wonderful! Yes, absolutely, we need to bump the version. |
raszi
added a commit
that referenced
this pull request
Aug 24, 2012
Export _getTmpName for temporary file name creation fixes #5
raszi
added a commit
that referenced
this pull request
May 11, 2015
Export _getTmpName for temporary file name creation fixes #5
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I am currently working on a module for node.js that runs an external process - this external process needs to get passed a file name to store its results in (until I read them from there and delete that file).
Currently I am using
require('tmp').tmpdirand generate the file name myself, but your_getTmpNamemethod does exactly this, so I would love to reuse it. Would it be possible to include it in the exports?Cheers,
Joscha