-
Notifications
You must be signed in to change notification settings - Fork 470
Updating build.zig to support new API change. #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I updated zig today and the addExecutable API appears to have changed with it. I was able to get the build to run again with this change.
I can't find any mistake. |
If you compare the zig versions, you can see that there were no changes in this function: https://ziglang.org/documentation/0.10.1/std/src/build.zig.html#L277 https://ziglang.org/documentation/master/std/src/build.zig.html#L384 |
It's in this commit that was merged into main 2 days ago: New function definition is on like 436 of std/Build.zig There's quite a few examples of the new config formatting in there. I'm just running the version of zig built by MacOS Brew. |
+1 PR calls it out explicitly: ziglang/zig#14498 benoberhaus@Bens-MBP ziglings % zig version
|
We are sorry but since they release new dev versions every few days, we can not make a new ziglings version in the same frequency. There are a lot of testing to make everything stable. The zig foundation is growing as sponsorship has increased, and now they have more fulltime devolopers. This means that the frequency of new versions will also increase, which we very much welcome. But we do not have the possibility to keep up with the pace if the quality is not to suffer. However, since ziglings is primarily for learning and understanding the zig language, we need to think about what to do. Maybe it's time to switch to the stable dev version of zig. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build number added
Updating build.zig to support new API change.
Updating build.zig to support new API change.
…dition into main Reviewed-on: https://codeberg.org/ziglings/exercises/pulls/177 Thank you @BGThompson for this great exercise!
I updated zig today and the addExecutable API appears to have changed with it. I was able to get the build to run again with this change.