-
Notifications
You must be signed in to change notification settings - Fork 470
build: fix build for latest zig version #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As part of ziglang/zig#14647 and more specifically this zig commit ziglang/zig@bf73620, the color is now communicated via env vars. Signed-off-by: Nicolas Sterchele <[email protected]>
Step's Options introduced from the following PR ziglang/zig#14647 and more precisely this commit ziglang/zig@02381c0 Also, MakeFn now takes a std.Progress.Node introduces by ziglang/zig@0e07879
Thank you for this hint, but there is something wrong. You have deleted the ziglings logo. 😮 |
The main reason I've removed it, is that I see two options:
Hope I was clear 😁 |
The problem is bigger and requires a general rebuild of the build system: #202 |
@chrboesch Happy to participate 👍🏼 |
@sterchelen You are welcome! 😄 |
Logo problem solved so far, but the main problem with asynchrounus tasks is still there: #203 |
@chrboesch I think our build.zig logic (with the new zig version that has the build "parallel" feature) is parallel aware by default as we are already leveraging zig's build step facilities; for each exercise we run I tried to run my PR on zig's master branch VS a checkout before the merge of ziglang/zig#14647 ; I confirm that the build is faster (though I don't have yet complete all the exercises, would be cool to see a whole run) One thing I noticed though is that the new build parallel feature doesn't respect the order of the exercices array. Finally, we could "cherry-pick" your header step fix from your PR into mine? side note: I am new to zig, so bear with me if I say/do stupid things 😬 |
@chrboesch it seems you did the job... closing then. |
No, I didn't. This is only a workaround that Ziglings can used manually. A real solution must work as before. What I did ist some experiments, but there are some bugs in the build system, so I opened an issue yesterday. The idea for a sustainable solution is to use the arguments in the build to select whether to compile all tasks one by one, and then re-run the build system one step at a time. In principal it works. I tested yesterday. |
@sterchelen Let's diskuss further here: #202 |
Currently, you can't build ziglings from zig's master branch (at the time of writing, ziglang/zig@c31007b is master's HEAD)
This patch set adapts ziglings' build code to reflect the changes on latest zig version.
A large and impactful change was made on zig's build facilities. The following PR ziglang/zig#14647 introduced those changes.
To be more precise, here are the impacts