Skip file overwrite if output is identical

[vlsi]

Currently java-comment-preprocessor always overwrites files, so java compiler always recompiles all the files.

Can JCP doublecheck if output is good enough and avoid file overwrites?

[raydac]

I think it is possible to implement such feature

[vlsi]

"maven-source-plugin" Invokes the execution of the lifecycle phase generate-sources prior to executing itself, thus if using maven-source-plugin and java-comment-preprocessor at the same time it forces maven to recompile the project twice.

[vlsi]

By the way: I like how smooth JCP integration is.

I use it to support multiple JDK versions for PostgreSQL JDBC driver: pgjdbc/pgjdbc#435.
It's just very basic "comment out java.sql.SQLType usage for JDK<1.8" stuff, and I like how JCP keeps line numbers intact.

[raydac]

I have added --z parameter into CLI and compareDestination into MAVEN and ANT f63d1ad
you can try the snapshot, now if into MAVEN add <compareDestination>true</compareDestination> then it will check content and will rewrite only if content is not the same

[vlsi]

Do you mean snapshot version is deployed somewhere?
Or should I build it from the sources?

[raydac]

you can build from sources or use brebuilt version https://drive.google.com/file/d/0BxHnNp97IgMRX05LZXNtbEVhZEE/view?usp=sharing

[vlsi]

Thanks for the quick fix.
f63d1ad works for me.

[INFO] Preprocess sources : /Users/vladimirsitnikov/Documents/code/pgjdbc2/core/src/main/java
[INFO] Preprocess destination : /Users/vladimirsitnikov/Documents/code/pgjdbc2/core/target/gen-src
[INFO] -----------------------------------------------------------------
[INFO] Completed, preprocessed 158 files, copied 0 files, elapsed time 403ms
[INFO] A Compile source root has been removed from the root list [/Users/vladimirsitnikov/Documents/code/pgjdbc2/core/src/main/java]
[INFO] The New compile source root has been added into the list [/Users/vladimirsitnikov/Documents/code/pgjdbc2/core/target/gen-src]
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ postgresql ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 16 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @ postgresql ---
[INFO] Nothing to compile - all classes are up to date

FYI: build without -DskipTests fails for me as follows:

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running com.igormaznitsa.jcp.it.ant.ITAntTask
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.218 sec - in com.igormaznitsa.jcp.it.ant.ITAntTask
Running com.igormaznitsa.jcp.it.maven.ITPreprocessorMojo
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.073 sec <<< FAILURE! - in com.igormaznitsa.jcp.it.maven.ITPreprocessorMojo
com.igormaznitsa.jcp.it.maven.ITPreprocessorMojo  Time elapsed: 0.072 sec  <<< ERROR!
org.apache.maven.it.VerificationException:
Failed to execute Maven: Failed to run Maven: Error while executing process.
/Users/vladimirsitnikov/Programs/apache-maven-3.3.9/bin/mvn -Dfile=/Users/vladimirsitnikov/Documents/work/java-comment-preprocessor/target/jcp-6.0.1-SNAPSHOT.jar -DpomFile=/Users/vladimirsitnikov/Documents/work/java-comment-preprocessor/pom.xml -e --batch-mode -Dmaven.repo.local=/Users/vladimirsitnikov/.m2/repository org.apache.maven.plugins:maven-clean-plugin:clean install:install-file
    at com.igormaznitsa.jcp.it.maven.ITPreprocessorMojo.setUpBeforeClass(ITPreprocessorMojo.java:65)
Caused by: org.apache.maven.it.LauncherException:
Failed to run Maven: Error while executing process.
/Users/vladimirsitnikov/Programs/apache-maven-3.3.9/bin/mvn -Dfile=/Users/vladimirsitnikov/Documents/work/java-comment-preprocessor/target/jcp-6.0.1-SNAPSHOT.jar -DpomFile=/Users/vladimirsitnikov/Documents/work/java-comment-preprocessor/pom.xml -e --batch-mode -Dmaven.repo.local=/Users/vladimirsitnikov/.m2/repository org.apache.maven.plugins:maven-clean-plugin:clean install:install-file
    at com.igormaznitsa.jcp.it.maven.ITPreprocessorMojo.setUpBeforeClass(ITPreprocessorMojo.java:65)
Caused by: org.apache.maven.it.util.cli.CommandLineException: Error while executing process.
    at com.igormaznitsa.jcp.it.maven.ITPreprocessorMojo.setUpBeforeClass(ITPreprocessorMojo.java:65)
Caused by: java.io.IOException: Cannot run program "/Users/vladimirsitnikov/Programs/apache-maven-3.3.9/bin/mvn" (in directory "/Users/vladimirsitnikov/Documents/work/java-comment-preprocessor/target/test-classes/com/igormaznitsa/jcp/it/maven/dummy_maven_project"): error=2, No such file or directory
    at com.igormaznitsa.jcp.it.maven.ITPreprocessorMojo.setUpBeforeClass(ITPreprocessorMojo.java:65)
Caused by: java.io.IOException: error=2, No such file or directory
    at com.igormaznitsa.jcp.it.maven.ITPreprocessorMojo.setUpBeforeClass(ITPreprocessorMojo.java:65)


Results :

Tests in error:
  ITPreprocessorMojo.setUpBeforeClass:65 » Verification Failed to execute Maven:...

[raydac]

the plug-in has a bit bizarre build process and you should have maven distributive on your machine and the way to the distributive should be directly placed into maven.home property in the pom.xml, it starts maven during integration tests
if for some time there are not new issues then I will publish the plugin in the maven central

[vlsi]

I see.

I just did a test via jitpack.io just for fun and it does not work:
https://jitpack.io/#raydac/java-comment-preprocessor/4238e69afd

Downloading: https://jitpack.io/com/github/raydac/java-comment-preprocessor/4238e69afd/java-comment-preprocessor-4238e69afd.pom
Downloaded: https://jitpack.io/com/github/raydac/java-comment-preprocessor/4238e69afd/java-comment-preprocessor-4238e69afd.pom (13 KB at 0.3 KB/sec)
Downloading: https://jitpack.io/com/github/raydac/java-comment-preprocessor/4238e69afd/java-comment-preprocessor-4238e69afd.jar
Downloaded: https://jitpack.io/com/github/raydac/java-comment-preprocessor/4238e69afd/java-comment-preprocessor-4238e69afd.jar (848 KB at 1002.8 KB/sec)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 43.995 s
[INFO] Finished at: 2015-11-29T00:29:50+03:00
[INFO] Final Memory: 11M/205M
[INFO] ------------------------------------------------------------------------
[ERROR] Invalid plugin descriptor for com.github.raydac:java-comment-preprocessor:4238e69afd (/Users/vladimirsitnikov/.m2/repository/com/github/raydac/java-comment-preprocessor/4238e69afd/java-comment-preprocessor-4238e69afd.jar), Plugin's descriptor contains the wrong group ID: com.igormaznitsa, Plugin's descriptor contains the wrong artifact ID: jcp, Plugin's descriptor contains the wrong version: 6.0.1-SNAPSHOT -> [Help 1]

[jitpack-io]

Hi @vlsi

Probably the issue is that JitPack rewrites groupId/artifactId to match the GitHub repository. Guessing that the original groupId is specified in the plugin descriptor.

[vlsi]

@raydac , would you mind releasing 6.0.1?