[rcore] Reviewed SDL3 gamepad detection #5176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brccabral This is a sensible change that can break gamepad detection for many users. Did you make sure this change works for multiple users, gamepads and OS configurations? |
raysan5
changed the title
|
Tested with two controllers, one Logitech (generic PS2) and one Press Play (generic Nintendo Switch), tested on Windows and Ubuntu. Used examples/core/core_input_gamepad.c for testing |
|
@brccabral Thanks for the review and confirming it works on Windows and Linux. Please, as you are also working on Web platform lately, could you also test the example on Web? Thanks! |
|
Example looks fine on the web. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDL3 joystick ID does not start from 0. In my case, my controllers were 4 and 5. First find the ID, then add to the platform/CORE.