-
Notifications
You must be signed in to change notification settings - Fork 24
Add TetraMeshData
class to handle tetrahedral mesh data
#407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TetraMeshData
class to handle tetrahedral mesh data
#407
Conversation
I'm a little unsure how a tetrahedral mesh fits in the primitive module? Primitives are meant to define a surface that may or may not enclose a volume. A tetrahedral mesh doesn't just represent a surface alone. We'd need to think about where this should live, or if the primitive definition should be extended. I've unfortunately not got much time to look through this at present as it is a large merge request. I will make one quick comment: the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo. |
As @CnlPepper mentioned,
I removed |
f6d4a2d
to
ab3b7bb
Compare
c6811e4
to
43bd751
Compare
TetraMesh
class to handle tetrahedral meshTetraMeshData
class to handle tetrahedral mesh data
I compressed mesh data in a
As you mentioned, I think the name I would appreciate it if you would take it into account. |
use cls variables to generate instance from class.
The latest Cython caused compile error at `kdtree2d.pyx` and `kdtree3d.pyx`
I noticed that priviouse `TetraMesh` was derived from `MeshData` so I should rename it to not confuse it with primitive object as well
dea9a5c
to
819737a
Compare
I would like to revisit this pull request to enhance the handling of tetrahedral meshes. |
I think that this PR contains many changes, making the review challenging, so I will separate features and propose each of them again. |
Hi,
I would like to propose this PR to introduce new class
TetraMesh
which is defined reffering toraysect.primitive.mesh.MeshData
.When constructing a kD tree for tetrahedral meshes,
MeshKDTree3D
class inraysect.core.math.function.float.function3d.interpolate.common
module was used, and I need more general way of handling tetrahedral vertices or indices.So, I decided to add some mesh-handling methods and put it into
raysect.primitive
module.According to this modification, I improved some implementations and documents.
In addition,
Tetmesh
in external package used in demo scripts:Py3DViewer
does not work well because of incompatible with version (I guess.), so I changed to usenumpy.load
method to load tetrahedral vertices and indices arrays.I would appreciate it if you would confirm my PR and marge it into develop branch:)