ci(actions): improve alignment of test configuration with React-Bootstrap #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per #179, the FireFox builds will likely not pass. This also comes with a change to make it more aligned with the React-Bootstrap testing configuration, by adding an additional step to build production files.
This is needed for the ci builds to be able to build on Firefox.
|
Oh snap, it's passing? 👀 I guess the fix has already been merged then. |
mxschmitt
approved these changes
Sep 4, 2019
taion
approved these changes
Sep 4, 2019
There was a problem hiding this comment.
we could, fwiw, get by with a somewhat smaller test matrix
i don't think we need ff on mac or windows. we really just want to check that our tooling works... and that's really mostly a windows thing (i.e. not forgetting to use cross-env, &c.)
but i guess as long as it's free, who cares XD
This commit doesn't add anything, as I'm attempting to re-trigger the CI build (since it errored out for an unknown bug).
|
|
|
updated the branch protection rules |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #179