Skip to content

Conversation

shaodahong
Copy link
Member

@vercel
Copy link

vercel bot commented Oct 17, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/rc-mentions/3mopy3spp
🌍 Preview: https://rc-mentions-git-upgrade-rc-trigger.react-component.now.sh

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #18 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   99.53%   99.53%   -0.01%     
==========================================
  Files           6        6              
  Lines         214      213       -1     
  Branches       45       45              
==========================================
- Hits          213      212       -1     
  Misses          1        1
Impacted Files Coverage Δ
src/KeywordTrigger.tsx 100% <ø> (ø) ⬆️
src/DropdownMenu.tsx 100% <100%> (ø) ⬆️
src/Mentions.tsx 99.23% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5cca9c...0880fd0. Read the comment docs.

@shaodahong
Copy link
Member Author

@zombieJ menu 的 ts 类型有问题,等会我去看看

@shaodahong
Copy link
Member Author

@zombieJ

  1. transitionName 的问题,我看原来的例子也是有问题的,例子中的 motion 虽然有定义,但实际上是 motion-enter motion-leave 来控制的,这个改下就行

  2. rc-trigger 的样式文件 @import "./index/Mask" 找不到,是不是构建的时候没有 copy 过去

@import "./index/Mask";
^
Can't resolve './index/Mask.less' in '/Users/shaodahong/Workspace/github/mentions/node_modules/rc-trigger/assets'

@shaodahong shaodahong changed the title refactor: upgrade rc-trigger [WIP] refactor: upgrade rc-trigger Oct 18, 2019
@zombieJ
Copy link
Member

zombieJ commented Oct 18, 2019

@shaodahong , 666~

@zombieJ
Copy link
Member

zombieJ commented Oct 18, 2019

包一个 Strict Mode 看看,没有报错我觉得就可以合了。

@shaodahong
Copy link
Member Author

rc-menu 那边的 warning

image

@shaodahong shaodahong changed the title [WIP] refactor: upgrade rc-trigger refactor: upgrade rc-trigger Oct 18, 2019
@zombieJ
Copy link
Member

zombieJ commented Oct 21, 2019

rc-menu 的不用管,这里好了就行。

@shaodahong
Copy link
Member Author

那没问题了,还有个疑问,这些 4.0 相关的改动不需要切一个新的分支么, 我看都是直接 master 发版

@zombieJ
Copy link
Member

zombieJ commented Oct 21, 2019

master 是最新代码,v3 的代码都在对应 repo 的分支里。

@shaodahong
Copy link
Member Author

发一版然后我去升级下 antd 试试

@vercel vercel bot temporarily deployed to staging October 22, 2019 06:05 Inactive
@zombieJ
Copy link
Member

zombieJ commented Oct 22, 2019

+ [email protected]

@shaodahong
Copy link
Member Author

publish 下?

@zombieJ
Copy link
Member

zombieJ commented Oct 22, 2019

[email protected] antd 里测试过了米?过了直接这个 PR 合了就行。

@shaodahong
Copy link
Member Author

我本地 link 过去运行 yarn test 测试是 OK 的,你合下吧,不是还要发[email protected] 版本么

@zombieJ zombieJ merged commit f6935db into master Oct 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the upgrade-rc-trigger branch October 23, 2019 12:27
@zombieJ
Copy link
Member

zombieJ commented Oct 23, 2019

https://www.npmjs.com/package/rc-mentions 已经发过了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants