Skip to content

fix: page count should be 1 when total is 0 #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2021
Merged

fix: page count should be 1 when total is 0 #344

merged 1 commit into from
Aug 8, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 8, 2021

@vercel
Copy link

vercel bot commented Aug 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/pagination/2BaA8DL8VDvYXhfZXuhWx3EMS34B
✅ Preview: https://pagination-git-fix-total-0-react-component.vercel.app

@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #344 (0367f59) into master (95307cb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files           3        3           
  Lines         327      327           
  Branches      113      112    -1     
=======================================
  Hits          302      302           
  Misses         25       25           
Impacted Files Coverage Δ
src/Pagination.jsx 90.94% <ø> (ø)
src/Pager.jsx 88.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95307cb...0367f59. Read the comment docs.

@afc163 afc163 merged commit 8f7c71b into master Aug 8, 2021
@afc163 afc163 deleted the fix-total-0 branch August 8, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination组件,total为0时,current 不是1
1 participant