fix accessbility issue #346
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/pagination/AGdWs1XJUAgErxnkJahCm4hmDTsy |
| @@ -123,6 +123,8 @@ class Options extends React.Component { | |||
| value={(pageSize || pageSizeOptions[0]).toString()} | |||
| onChange={this.changeSize} | |||
| getPopupContainer={(triggerNode) => triggerNode.parentNode} | |||
| aria-label={locale.page_size} | |||
| defaultOpen={false} | |||
There was a problem hiding this comment.
| defaultOpen={false} |
defaultOpen={false} could be deleted.
There was a problem hiding this comment.
We need defaultOpen to set the Input components aria-expanded props and fix the accessibility issue. For the detail you can check my this comment: ant-design/ant-design#31692 (comment)
There was a problem hiding this comment.
@afc163 Any other problems here?
|
Can anybody update in which version this fix available? |
|
fix: bugfix
Detail:
To fix the accessibility issues of pagination. Now the inputbox and select of pagination have the accessibility issues. For the detail please see the issues: #345
Solution:
Add the
aria-labelanddefaultOpenvalue for the select and input component.