Skip to content

fix: showTotal should work on simple mode #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2022

Conversation

KevinBrother
Copy link
Contributor

simple 支持 showTotal 的配置选项

simple 不覆盖会 showTotal 配置选项
@vercel
Copy link

vercel bot commented Aug 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pagination ✅ Ready (Inspect) Visit Preview Aug 21, 2022 at 9:52AM (UTC)

@yoyo837
Copy link
Member

yoyo837 commented Aug 19, 2022

设计好像就是simple不展示total,这是符合设计预期的。

@afc163 afc163 changed the title Update Pagination.jsx feat: showTotal should work on simple mode Aug 19, 2022
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #433 (448e5ae) into master (4d65a3d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   93.00%   92.98%   -0.03%     
==========================================
  Files           3        3              
  Lines         343      342       -1     
  Branches      120      121       +1     
==========================================
- Hits          319      318       -1     
  Misses         24       24              
Impacted Files Coverage Δ
src/Pagination.jsx 91.82% <100.00%> (-0.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afc163 afc163 changed the title feat: showTotal should work on simple mode fix: showTotal should work on simple mode Aug 19, 2022
@afc163 afc163 merged commit 31b616c into react-component:master Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants