refactor hook and support ref #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@afc163 这个ci是配置有问题把 |
|
配置没问题，仔细观察一下。
|
|
都没有hsx的文件吧 |
|
jsx |
|
需要加上 tsx |
|
改成这样吧，再把出现的问题顺便修掉。 - "lint": "eslint src/ --ext .jsx,.js,.md",
+ "lint": "eslint .", |
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
============================================
+ Coverage 89.28% 100.00% +10.71%
============================================
Files 1 1
Lines 56 43 -13
Branches 13 12 -1
============================================
- Hits 50 43 -7
+ Misses 6 0 -6
Continue to review full report at Codecov.
|
|
覆盖率也顺便提上来吧，应该就两三行没覆盖到。 |
hengkx
commented
May 17, 2020
afc163
reviewed
May 17, 2020
afc163
reviewed
May 17, 2020
|
刚刚有其它依赖 更新了吗？？ |
|
eslint ignore 掉就行 |
|
发个版本 |
|
|
|
2.x 理论上 React 15 还能用。react-component/progress#82 |
zombieJ
reviewed
May 18, 2020
| if (autoFocus && !disabled) { | ||
| this.focus(); | ||
| focus(); |
There was a problem hiding this comment.
我处理下 ，批量替换了this,... 竟然不报错
zombieJ
reviewed
May 18, 2020
| } | ||
| } | ||
| }, [props.autoFocus, props.disabled]); |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
准备移除废弃api ant-design/ant-design#22493