Skip to content

fix: auto focus #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020
Merged

fix: auto focus #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ const Switch = React.forwardRef<HTMLButtonElement, SwitchProps>((props, ref) =>
React.useEffect(() => {
const { autoFocus, disabled } = props;
if (autoFocus && !disabled) {
focus();
(mergedRef.current as any).focus();
}
}, [props.autoFocus, props.disabled]);
}, [props.autoFocus]);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自动获取焦点 需要根据属性改变做出响应吗？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用：

ref: https://github.com/facebook/react/blob/b4a1a4980c98c6d8a7ced428a1adc9e278fec430/packages/react-dom/src/client/ReactDOMHostConfig.js#L430

Copy link
Member

@zombieJ zombieJ May 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hengkx 这个你先不用动了，我这边有一部分其他重构。会一起弄掉哈。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok


React.useEffect(() => {
if ('checked' in props) {
Expand Down