Skip to content

add onHeaderClick on column properties #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ds3783
Copy link

@ds3783 ds3783 commented Feb 25, 2017

In out product document, product manager require a feature that is: when user click table header, system popup a modal dialog which explain that specific column is how generated.
Thus, I think we need a event listener function pass to the "th" element.

@ds3783 ds3783 closed this Feb 25, 2017
@ds3783 ds3783 reopened this Feb 25, 2017
@ds3783 ds3783 closed this Feb 25, 2017
@ds3783 ds3783 reopened this Feb 25, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 90.717% when pulling 71b661b on ds3783:master into 048aaa3 on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 90.717% when pulling 71b661b on ds3783:master into 048aaa3 on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 90.717% when pulling 71b661b on ds3783:master into 048aaa3 on react-component:master.

@yesmeck
Copy link
Member

yesmeck commented Feb 27, 2017

Try using column[title]:

const columns = [
  { title: <span onClick={handleTittleClick}>Name</span> }
];

@ds3783
Copy link
Author

ds3783 commented Feb 27, 2017

the clickable area did cover padding of "th" !

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 90.756% when pulling 71b661b on ds3783:master into 7db2d43 on react-component:master.

@henryzp
Copy link

henryzp commented Apr 25, 2017

@ds3783 , it can use now?

@henryzp
Copy link

henryzp commented Apr 25, 2017

Does this onHeadClick not need to provide parameters?

Because in my needs inside, I was hoping to click thead to be able to sort。I need to know some information, such as the current thead。

I see your code,but it cannot help me

@yesmeck
Copy link
Member

yesmeck commented Nov 13, 2017

#171

@yesmeck yesmeck closed this Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants