Adding ability to control state from refs during onDrag #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when you need to manage setState from refs
When controlling state from refs return before state gets set inside handleDrag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When dragging it's a challenge to manage state from refs because internally
this.setStatewill always override anyrefs.setStatemaking it useless.Even if you return false from the function DraggableCore will
this.handleDragStop(new MouseEvent('mouseup'));trigger drag stop.Solution
Return an object with a key
controlledand if it's true it will short circuit onDrag giving the custom callback the ability to control the state.https://www.loom.com/share/2ca4ef824bc2404bac0cbf2f8108de2c