Skip to content

Fix pod install on RN 0.70.x + New Arch #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2023
Merged

Fix pod install on RN 0.70.x + New Arch #1004

merged 1 commit into from
Aug 24, 2023

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Aug 22, 2023 •
edited
Loading

Summary

Issue: #997

Test Plan

npx [email protected] init Rn70New --version 0.70.13
cd Rn70New
yarn add "https://gitpkg.now.sh/retyui/async-storage/packages/default-storage-backend?fix-new-arch-pod-install"
# add "platform :ios, '13.4'" in  `ios/Podfile` 
RCT_NEW_ARCH_ENABLED=1 npx pod-install
Screenshot 2023-08-22 at 14 19 58

@retyui retyui marked this pull request as ready for review August 22, 2023 12:20
@retyui retyui mentioned this pull request Aug 22, 2023
Closed
5 tasks
krizzu
krizzu reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - @tido64 mind having a look here? 🙏

tido64
tido64 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@tido64 tido64 linked an issue Aug 24, 2023 that may be closed by this pull request
pod install fail on RN 0.70.x & New Arch #997
Closed
5 tasks
@tido64 tido64 merged commit e15432c into react-native-async-storage:main Aug 24, 2023
@AsyncStorageBot
Copy link
Collaborator

🎉 This PR is included in version 1.19.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krizzu krizzu krizzu left review comments

@tido64 tido64 tido64 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pod install fail on RN 0.70.x & New Arch
4 participants
@retyui @AsyncStorageBot @tido64 @krizzu