chore: upgrade detox #95
Conversation
|
Android now uses android test implementation |
There was a problem hiding this comment.
Thanks for bringing this up 🥇
I left few comments, mind having a look?
Quoting:
Detox 12 has been released with Xcode 10.2 support and minimum Xcode version of 10.1.
This mean a breaking change for someone who did not upgrade their Xcode. So here's a real deal: should we merge this PR and put a note about Xcode support or hold for some time before doing that transition?
CC @tido64
thanks.
| @@ -117,8 +117,7 @@ android { | |||
| versionCode 1 | |||
| versionName "1.0" | |||
| testBuildType System.getProperty('testBuildType', 'debug') | |||
| missingDimensionStrategy "minReactNative", "minReactNative46" | |||
| testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner" | |||
| testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" | |||
There was a problem hiding this comment.
Any particular reason to move to androidx? I haven't seen anything in Detox's migration guide that mention it. I've seen (and had) a bad experience with mixing support libs with androidx in one project, so ideally we'd love to avoid that conflict.
There was a problem hiding this comment.
When migrated from 10.x to 11.x androidx is necessary for detox
|
@krizzu: Regarding Xcode, one should be on at least 10.1 nowadays to build for latest iOS. But isn't this just if you need to compile the tests? Regular consumers should not be affected, correct? |
|
as @tido64 mentioned, Xcode 10.1 is necessary only for contributors, it doesn't effect users
|
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Upgrade detox:
Upgrade detox for xcode 10 and above support
closes #94