Enable builds on CircleCI #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengjiawen
approved these changes
Nov 15, 2018
|
@gengjiawen there you go -> https://circleci.com/gh/react-community/jsc-android-buildscripts/31?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link From now on links will be automatically added to the CI section on PRs |
|
https://circleci.com/gh/gengjiawen/jsc-android-buildscripts/15, here is the previous build on docker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI builds will make it much easier in the future to test PRs but also automate deployments, and will help verify that the binaries we publish comes from reproductible builds. Currently there is a CI running at wix which can only be accessed by a few people. Having builds run on a public CI service will make the whole process more transparent and also easier to troubleshoot in case os issues.
It took me a while to restore builds to work on CircleCI and the root cause of all the problems seemed to be docker environment. While running inside docker the builds will often crash (segfault) during random commands (clang or when running python). We also observed that strange behavior when running on our own hosts inside docker. In order for it to work I had to switch circleCI config from using docker to "machine" which runs some other notion of virtualization.