Skip to content

Upgrade WebKitGTK+ to 2.22.6 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

Kudo
Copy link
Member

@Kudo Kudo commented Feb 21, 2019

Closes #85
For security vulnerabilities: https://webkitgtk.org/security/WSA-2018-0009.html

Tested on my arm device with RNTester okay.
I don't have a Pixel phone and cannot update measurement result as these result are from Pixel phone.

Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets get this landed and see what CI says. Thanks @Kudo

@kmagiera kmagiera merged commit c9cdc0b into react-native-community:master Feb 27, 2019
@rotemmiz
Copy link

rotemmiz commented Mar 5, 2019

Hey @kmagiera, is there something holding back the release of 241213.x.x ? I really want to test if the issue reported in #84 is resolved.

@kmagiera
Copy link
Member

kmagiera commented Mar 6, 2019

Hi @rotemmiz – no there is nothing really. I just haven't had a chance to try that version by myself. I can publish it on npm with "beta" tag and would appreciate if you could verify if it work for you

@kmagiera
Copy link
Member

kmagiera commented Mar 6, 2019

image

Just published 241213.0.0 tagged as "canary" would appreciate any comments if you get a chance to try it.

@rotemmiz
Copy link

rotemmiz commented Mar 6, 2019

Unfortunately, the same crash persists on 241213 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants