Skip to content

feat: allow mac catalyst build #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2020
Merged

feat: allow mac catalyst build #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/RNCPushNotificationIOS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ extern NSString *const RNCRemoteNotificationReceived;

typedef void (^RNCRemoteNotificationCallback)(UIBackgroundFetchResult result);

#if !TARGET_OS_TV && !TARGET_OS_UIKITFORMAC
#if !TARGET_OS_TV
+ (void)didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings;
+ (void)didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken;
+ (void)didReceiveRemoteNotification:(NSDictionary *)notification;
Expand Down
12 changes: 6 additions & 6 deletions ios/RNCPushNotificationIOS.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,11 @@ + (UNNotificationCategory *)UNNotificationCategory:(id)json
#else
@interface RNCPushNotificationIOS () <NativePushNotificationManagerIOS>
@end
#endif //TARGET_OS_TV / TARGET_OS_UIKITFORMAC
#endif //TARGET_OS_TV

@implementation RNCPushNotificationIOS

#if !TARGET_OS_TV && !TARGET_OS_UIKITFORMAC
#if !TARGET_OS_TV

/**
* Type deprecated in iOS 10.0
Expand Down Expand Up @@ -288,7 +288,7 @@ @implementation RNCPushNotificationIOS
return formattedResponse;
}

#endif //TARGET_OS_TV / TARGET_OS_UIKITFORMAC
#endif //TARGET_OS_TV

RCT_EXPORT_MODULE()

Expand All @@ -297,7 +297,7 @@ - (dispatch_queue_t)methodQueue
return dispatch_get_main_queue();
}

#if !TARGET_OS_TV && !TARGET_OS_UIKITFORMAC
#if !TARGET_OS_TV
- (void)startObserving
{
[[NSNotificationCenter defaultCenter] addObserver:self
Expand Down Expand Up @@ -688,7 +688,7 @@ - (void)handleRemoteNotificationRegistrationError:(NSNotification *)notification
}
}

#else //TARGET_OS_TV / TARGET_OS_UIKITFORMAC
#else //TARGET_OS_TV

RCT_EXPORT_METHOD(onFinishRemoteNotification:(NSString *)notificationId fetchResult:(NSString *)fetchResult)
{
Expand Down Expand Up @@ -774,6 +774,6 @@ - (void)handleRemoteNotificationRegistrationError:(NSNotification *)notification
return @[];
}

#endif //TARGET_OS_TV / TARGET_OS_UIKITFORMAC
#endif //TARGET_OS_TV

@end