Skip to content

feature/update docs with linking #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2020
Merged

feature/update docs with linking #33

merged 3 commits into from
Jan 7, 2020

Conversation

calintamas
Copy link
Contributor

@calintamas calintamas commented Oct 10, 2019 •
edited
Loading

Docs were unclear for the linking part, particularly when upgrading to 0.60+

cosmith
cosmith reviewed Dec 3, 2019
View reviewed changes
Naturalclar
Naturalclar approved these changes Jan 7, 2020
View reviewed changes
Copy link
Collaborator

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goods to me, thanks!

@Naturalclar Naturalclar merged commit 439c28f into react-native-push-notification:master Jan 7, 2020
@calintamas calintamas deleted the feature/update-docs branch January 7, 2020 17:10
@snyk-bot snyk-bot mentioned this pull request Mar 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

+1 more reviewer

@cosmith cosmith cosmith left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calintamas @cosmith @Naturalclar