Skip to content

add typescript typings #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

add typescript typings #37

merged 1 commit into from
Jan 7, 2020

Conversation

jsamr
Copy link
Contributor

@jsamr jsamr commented Oct 17, 2019

Summary

  • Add index.d.ts
  • Add a reference in package.json

I have been using those definitions for a few months now, happy to share.

@jakebloom
Copy link

Thanks so much for doing this!

One that has been missed: removeAllDeliveredNotifications

Naturalclar
Naturalclar approved these changes Jan 7, 2020
View reviewed changes
Copy link
Collaborator

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I'll add the missing types once I merge this :)

@Naturalclar Naturalclar merged commit b07c746 into react-native-push-notification:master Jan 7, 2020
@Naturalclar Naturalclar mentioned this pull request Jan 7, 2020
Merged
1 task
@snyk-bot snyk-bot mentioned this pull request Mar 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsamr @jakebloom @Naturalclar