updates to README.md #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht in line with linter recommendations
|
sorry that took so long |
Naturalclar
approved these changes
Feb 25, 2020
|
@Naturalclar Hello, when can we see this published as new version on npm and pods? |
Merged
|
@capJavert published as 1.0.7 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
updated to reflect need for UNUserNotificationCenter. also brought README.md in line with markdown linter recommendations.
this is the result if my having struggled with it not working out of the box and stumbling on the solution, and a desire to help other avoid that.
Test Plan
I think this is not required for a readme change? other than to note that by following it my app now compiles and can push messages to a real device?
What's required for testing (prerequisites)?
see above?
What are the steps to reproduce (after prerequisites)?
a working app.
Compatibility
Checklist
README.mdCHANGELOG.md// I don't see a change log in the repo?example/App.js) // not applicable