Skip to content

Why is completion never called when reporting new incoming call on ios? #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rcidt opened this issue Feb 27, 2020 · 3 comments
Closed

Comments

@rcidt
Copy link

rcidt commented Feb 27, 2020

I am getting reports from some iOS users that incoming calls stop coming in after a few days.

I am thinking this is because iOS is blocking the VoIP notifications because for some reason the incoming calls are not being reported to the system.

I think it might have to do with the fact that CallKeep never calls the completion handler when reporting the new incoming call to ios here:

    [sharedProvider reportNewIncomingCallWithUUID:uuid update:callUpdate completion:^(NSError * _Nullable error) {
        RNCallKeep *callKeep = [RNCallKeep allocWithZone: nil];
        [callKeep sendEventWithName:RNCallKeepDidDisplayIncomingCall body:@{ @"error": error ? error.localizedDescription : @"", @"callUUID": uuidString, @"handle": handle, @"localizedCallerName": localizedCallerName, @"hasVideo": hasVideo ? @"1" : @"0", @"fromPushKit": fromPushKit ? @"1" : @"0" }];
        if (error == nil) {
            // Workaround per https://forums.developer.apple.com/message/169511
            if ([callKeep lessThanIos10_2]) {
                [callKeep configureAudioSession];
            }
        }
    }];

Is there a reason we don't call completion(error) at the end of the block?

rcidt pushed a commit to net2phone/react-native-callkeep that referenced this issue Feb 27, 2020
rcidt pushed a commit to net2phone/react-native-callkeep that referenced this issue Feb 27, 2020
rcidt pushed a commit to net2phone/react-native-callkeep that referenced this issue Feb 27, 2020
@rcidt rcidt closed this as completed Feb 27, 2020
@danjenkins
Copy link
Collaborator

@rcidt what conclusion did you come to?

@rcidt
Copy link
Author

rcidt commented Mar 6, 2020

@danjenkins I closed this ticket because I realized the code change I was requesting is not valid.

The issue at hand is still happening, and I opened another issue for it here: #163

@DaveLomber
Copy link

Same issue here - completion never called ;(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants