Skip to content

Improvement - Should be able to override the Alert on android #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danjenkins opened this issue Apr 23, 2019 · 6 comments
Open

Improvement - Should be able to override the Alert on android #36

danjenkins opened this issue Apr 23, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@danjenkins
Copy link
Collaborator

I should be able to make the alert look and feel like the rest of my app - for example using Modal from react-native-paper

@sboily
Copy link
Member

sboily commented Apr 23, 2019

Hello, not sure to understand this point, are you talking about the popup coming from android when you received a call?

@danjenkins
Copy link
Collaborator Author

Sorry @sboily - no the alert that pops up at the start to say "enable the phone account" in https://github.com/react-native-webrtc/react-native-callkeep/blob/master/index.js#L148

@sboily
Copy link
Member

sboily commented Apr 23, 2019

Ok thank you! Are you working on this feature for a PR or is it a request feature?

@danjenkins
Copy link
Collaborator Author

danjenkins commented Apr 23, 2019 via email

@danjenkins danjenkins added the enhancement New feature or request label Jun 12, 2019
manuquentin pushed a commit that referenced this issue Sep 27, 2019
Differentiate intent type comparisons for iOS 13
@manuquentin
Copy link
Contributor

Hi @danjenkins is this still an issue for you ?

@danjenkins
Copy link
Collaborator Author

Yup - an enhancement still :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants