Incoming call not displaying it's a video call

[ThomasLarge]

I have a function that is being called when I get a notification but I can't get it to say Video and not audio. Bellow is the function

onIncomingCall(callUuid) {
   RNCallKeep.displayIncomingCall(callUuid, "Thomas Large", null, true);
}

True is the way the docs tells you how to set it

Can anyone help?

[tienviip]

hi @ThomasLarge have you found a solution for videocall, please support me.

[ThomasLarge]

@tienviip do you mean how to get it working? or the issue I have above?

[tienviip]

@ThomasLarge yep, I also encountered your problem above, Can you help me, please.

[ThomasLarge]

@tienviip I'm waiting on someone to help me too 😆 I'm going to try and dig into it later but haven't got the time at the moment that's why I have opened the issue

[LinusU]

The problem is probably that hasVideo is hard-coded to NO here:

react-native-callkeep/ios/RNCallKeep/RNCallKeep.m

Line 135 in 7d73060

callUpdate.hasVideo = NO;

[ThomasLarge]

@LinusU Looks like it's here too

react-native-callkeep/ios/RNCallKeep/RNCallKeep.m

Line 254 in 7d73060

callUpdate.hasVideo = NO;

Do you think it's best to change the file locally or is it best to wait until the repo has been updated?

[danjenkins]

Update it locally, see if it fixes your issue and then submit a PR with it configurable :) in all likelihood it won't get fixed unless you fix it!

…

On Wed, 26 Jun 2019, 13:12 Thomas Large, ***@***.***> wrote: @LinusU <https://github.com/LinusU> Looks like it's here too https://github.com/react-native-webrtc/react-native-callkeep/blob/7d7306027834da68f488b4d88bb1ad9910e9348b/ios/RNCallKeep/RNCallKeep.m#L254 Do you think it's best to change the file locally or is it best to wait until the repo has been updated? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#54?email_source=notifications&email_token=AAB3LLJSYIJU4YKKPAONIY3P4NMKDA5CNFSM4HRYEMK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYTKC6Y#issuecomment-505848187>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB3LLOKBIEFQNETMYIKQK3P4NMKDANCNFSM4HRYEMKQ> .

[ThomasLarge]

@danjenkins & @LinusU I have changed that file and it doesn't seem to work still I think there's more places it's hardcoded or it's something that isn't working in the package. I haven't got the time over the next couple of days to look into it more but I will over the weekend. There's also these two lines

react-native-callkeep/index.js

Line 48 in 5cae457

displayIncomingCall = (uuid, handle, localizedCallerName, handleType = 'number', hasVideo = false) => {

react-native-callkeep/index.js

Line 57 in 5cae457

startCall = (uuid, handle, handleType = 'number', hasVideo = false, contactIdentifier) => {

[danjenkins]

@ThomasLarge @LinusU

So you need to change

react-native-callkeep/ios/RNCallKeep/RNCallKeep.m

Line 135 in 7d73060

callUpdate.hasVideo = NO;

's NO to hasVideo

I'd just comment out the line

react-native-callkeep/ios/RNCallKeep/RNCallKeep.m

Line 254 in 7d73060

callUpdate.hasVideo = NO;

@ThomasLarge those 2 links to the index.js are just setting a default of false. If you pass in true it'll be true :)

Make sure you close down your metro packager etc etc and build from scratch with the change done locally in your node_modules directory if you want to test it out :)

[ThomasLarge]

Cheers @danjenkins I will look at this tomorrow or the weekend

[ThomasLarge]

I can confirm this is all fixed 👍