Skip to content

indes.d.ts file isnt in sync with CallKeep APIs #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
msuma268 opened this issue Sep 3, 2019 · 1 comment
Closed

indes.d.ts file isnt in sync with CallKeep APIs #90

msuma268 opened this issue Sep 3, 2019 · 1 comment

Comments

@msuma268
Copy link

msuma268 commented Sep 3, 2019

API signatures in index.d.ts and the one supported by latest CallKeep version are not in sync.

Ex: setCurrentCallActive takes call UUID as argument in latest version. But in index.d.ts, setCurrentCallActive is declared with no arguments. If typescript check is enabled on the javascript. then error is shown in IDE with prompt to invoke method without any arguments.

There is no updateDisplay API available in index.d.ts..
@manuquentin
Copy link
Contributor

Fixed in #96

@kafkas kafkas mentioned this issue Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manuquentin @msuma268