Skip to content

Minor updates #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Minor updates #96

merged 2 commits into from
Sep 16, 2019

Conversation

manuquentin
Copy link
Contributor

const updateDisplay = (callUUID) => {
const number = calls[callUUID];
// Workaround because Android doesn't display well displayName, se we have to switch ...
if (isIOS) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylekurz @bhuangy @danjenkins on Android I have to switch displayName and handle arguments to have them displayed correctly (unless the displayName is not taken in account).
Weirdly the Android code seems to be OK ...

Have you this issue too ? I can reproduce with the example on a Pixel 1 (Android 9).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use the updateDisplay api yet so I can't comment :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather update the underlying modules so they can both have the arguments in the same order, instead of doing a platform check here, personally...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too but my point is that the arguments on the Android side are good. I don't want to call setAddress with the displayName and setCallerDisplayName with the handle ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really make sense. We should be figuring out what's going on underneath instead of providing a strange example.

For our app, we have the following scenarios:

  1. Incoming call - Always displays name properly
  2. Outgoing call started from our app - Always displays name properly
  3. Outgoing call started from native dialer - Only displays the number

Does this match your experience? I think if you switch the items, you'll end up with a call log that has the right name, but the URI will be useless if someone tries to call it back.

@manuquentin manuquentin merged commit 824a602 into master Sep 16, 2019
@manuquentin manuquentin deleted the minor_update branch September 16, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants