Fix outgoing native samsung #100
Conversation
manuquentin
force-pushed
the
fix_outgoing_native_samsung
branch
from
0f0e5a5 to
f370e3b
Compare
manuquentin
changed the title
manuquentin
force-pushed
the
fix_outgoing_native_samsung
branch
2 times, most recently
from
9d78f85 to
5d5695d
Compare
manuquentin
force-pushed
the
fix_outgoing_native_samsung
branch
from
5d5695d to
3ad5345
Compare
|
This is a weird issue that sounds like a Samsung bug. How did you determine that the setInitialized() call was breaking it? Did you file a bug with Samsung's developer program about it? I'd personally be ok merging this after some testing, but would like a comment above the manufacturer check with a link to the Samsung ticket so if they ever fix it, we know what to remove. |
|
Tested it and it does fix the bug where the ConnectionService UI wasn't showing before. |
|
@manuquentin We have tickets in our project waiting on this to merge too, can that happen soon, or should we manage it on our fork for now? |
|
Hi @kylekurz |
|
👉 |
|
Not sure I'll get an answer about it 🤷♂️ but asked nevertheless. |
On some Samsung phones (with android >= 9), we're expecting an issue when making a call from the native phone application: the ConnectionService UI doesn't appear.
Digging in the code shows that calling
setInitializedon the connection block the display (without any signifiant log from Android).But the call to
setInitializeddoesn't appears to be required to display the call correctly via ConnectionService, so we can skip it on Samsung phones.