Skip to content

#108 Address Outgoing calls not working from call log in iOS 13 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 27, 2019
Merged

#108 Address Outgoing calls not working from call log in iOS 13 #109

merged 5 commits into from
Sep 27, 2019

Conversation

bhuangy
Copy link
Contributor

@bhuangy bhuangy commented Sep 26, 2019 •
edited
Loading

  • Found that iOS 13 changed the return value in userActivity.activityType to a generic INStartCallIntent. We're now using intent.callCapability as to determine an audio vs video call.
  • Found a bug that resulted in the app always showing as video capable in the iOS Recents call details page. Specifically, the providerConfiguration was being assigned the incorrect value for supportsVideo. Fixed it along with this PR because they're somewhat related.
    Fixes iOS13: Outgoing call not working from call log. #108

@bhuangy bhuangy changed the title Issue #108 Address Outgoing calls not working from call log in iOS 13 #108 Address Outgoing calls not working from call log in iOS 13 Sep 26, 2019
@manuquentin manuquentin mentioned this pull request Sep 27, 2019
Closed
@kylekurz
Copy link
Contributor

+1 for this going in. Good work @bhuangy

@kylekurz kylekurz mentioned this pull request Sep 27, 2019
Closed
3 tasks
@manuquentin
Copy link
Contributor

manuquentin commented Sep 27, 2019 •
edited
Loading

Tested and functional 👌
Thanks @bhuangy

Released in 3.0.4

@manuquentin manuquentin merged commit 154e10a into react-native-webrtc:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS13: Outgoing call not working from call log.
3 participants
@bhuangy @kylekurz @manuquentin