Skip to content

Add a troubleshooting note on using a valid uuid #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

sanjaypojo
Copy link
Contributor

Was stuck for some time trying to figure out why the incoming call wasn't being received and it turned out, it was simply because I had supplied an invalid uuid. The didDisplayIncomingCall method also returns without any errors, so there's no explanation for why the screen didn't show up. Might be great if the library threw an error in didDisplayIncomingCall if an invalid uuid is supplied.

Was stuck for some time trying to figure out why the incoming call wasn't being received and it turned out, it was simply because I had supplied an invalid `uuid`.  The `didDisplayIncomingCall` method also returns without any errors, so there's no explanation for why the screen didn't show up. Might be great if the library threw an error in `didDisplayIncomingCall` if an invalid `uuid` is supplied.
@danjenkins
Copy link
Collaborator

Are you using v4 uuid @sanjaypojo? That's what I use - maybe best to be clear what type of uuid while you're at it? Could you add that?

@sanjaypojo
Copy link
Contributor Author

@danjenkins I've tested that it works with both v4 and v5. I've updated the text and only mentioned v4 since it's simpler (v5 needs a salt etc.) and consistent with the example as well. Let me know if you want other changes!

@danjenkins
Copy link
Collaborator

thanks @sanjaypojo !

@danjenkins danjenkins merged commit db30f10 into react-native-webrtc:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants