Fix Video button not working in iOS Lock Screen #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leethree
added a commit
to ef-carbon/react-native-callkeep
that referenced
this pull request
Apr 1, 2020
|
I'm getting this when making these changes:
|
|
@zenkhas check 3.0.12, it's likely not related to this PR. |
|
@manuquentin any comments? |
This was referenced Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When answering the call, if iOS user is in a lockscreen and then want to press video button to go to the app. The current behavior is that button just do nothing. The issue related to the way we hardcoded the handleType when set up "providerConfiguration". I tried to make it dynamic as much as possible via user's settings and the default value should be CXHandleTypeGeneric because our example for reportingNewIncomingCall using generic as well.