Skip to content

Migrate to Android X #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Migrate to Android X #210

merged 2 commits into from
Jul 29, 2020

Conversation

maximvoven
Copy link
Contributor

@maximvoven maximvoven commented Jun 4, 2020

Since V60.6 of react native android x is natively supported, this pull modernizes this library.
What Changes:
-Migrated to android Android X using jetifier
-Small change to build.gradle to get rid of warnings during compiling about build tools
-Set compile api level to minimum for android play store.

@danjenkins
Copy link
Collaborator

Once this gets merged it should be released under a major version change - what do you think @manuquentin @sboily

@sboily
Copy link
Member

sboily commented Jun 9, 2020

Sound good to me.

@manuquentin
Copy link
Contributor

Does it mean that it will not work with react-native <= 60.5 ?
Should we maintain 2 versions: 3.xx for react-native > 60.5 and 2.xx for react-native <= 60.5 ?

@sboily
Copy link
Member

sboily commented Jun 30, 2020

Probably we could stop to maintain the 2.xx version, only the 3.xx with react-native > 60.5. Is there any objections to do that?

@danjenkins
Copy link
Collaborator

Ultimately there are tools like jettifier to bring this up to work with androidx and bring an androidx package down to work with RN 0.60.5 (or whatever the version is)

@manuquentin
Copy link
Contributor

@maximvoven thanks for the PR !
Can you rebase it on master ?

@sboily
Copy link
Member

sboily commented Jul 29, 2020

@maximvoven can you rebase your branch for a merging please :) Thank you!

@maximvoven
Copy link
Contributor Author

Branch is re-based and ready for merging, sorry about the delay

@manuquentin manuquentin merged commit 1a4e31a into react-native-webrtc:master Jul 29, 2020
@Kelt Kelt mentioned this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants