-
Notifications
You must be signed in to change notification settings - Fork 462
Allow user to handle phone account manually #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Open app in headless mode, pass additional callUUID
Thanks @jpudysz for the PR. I'll take a look. Meanwhile, can you rebase it on master ? |
@manuquentin yup, looks good. It will improve UX a lot. Edit: |
This PR is great, when is this due to be merged? |
Hello everyone, I'm super busy and I can't contribute here, what's more, we are far behind each other. You can check my repo with a few additional improvements for Android (https://github.com/jpudysz/react-native-callkeep) - tested on production as I'm developing for my client's VoIP app. I tried to create PR here, but I changed backToForeground logic and it differs from original repo. New functionality such as headless mode, locked screen are strictly connected with this function and I can't merge it. Ideally, we can take my ideas and merge it with the master (I don't mind and you can copy-paste my code under your PR). Ping me if I needed. PS. I added changelog inside my repo, so you can check new functionalities. |
This small PR allows user to handle phone account flow manually.
Currently, the library is too obtrusive and it can be an issue for a well-designed app which doesn't want to display ugly Android alert.
What I'm proposing is another way for the developer to handle Android's phone account. Changes are backwards compatible so it can be released as a minor version.
How
react-native-callkeep
works now:microphone
,camera
andphone state
permissions manually. If user accepts it beforeRNCallKeep.setup
, library won't display any promptssetup
JS part of the lib will prompt the user to enable phone account and we can only inject alert's title and messageHow library will work with this PR merged to master:
checkPhoneAccountEnabled
setup
) with new methodregisterPhoneAccount
- with such option we can prompt the user and navigate to account settings manually, we can use our UI eg.:setup
library and enjoy CallKeep without any additional alerts or prompts ;)