-
Notifications
You must be signed in to change notification settings - Fork 462
Audio route to speaker for Android platform #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
manuquentin
merged 13 commits into
react-native-webrtc:master
from
vtn-dev-prithipal:speakerOutputAndroid
Mar 22, 2021
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
be5f3fb
Audio route to speaker for Android platform
vtn-dev-prithipal adc6bba
Merge branch 'master' of https://github.com/react-native-webrtc/react…
vtn-dev-prithipal 49d984f
review suggestion changes updated
vtn-dev-prithipal 3fc6c55
added function documenttation
vtn-dev-prithipal c34ae22
Merge branch 'master' of https://github.com/react-native-webrtc/react…
vtn-dev-prithipal 749318c
Update the param naming convension
vtn-dev-prithipal 6c4a7cb
Update index.d.ts
vtn-dev-prithipal b0a2fda
Added documentation for toggleAudioRouteSpeaker function
vtn-dev-prithipal 7c69d82
Merge branch 'speakerOutputAndroid' of https://github.com/vtn-dev-pri…
vtn-dev-prithipal 4dd66ad
Update README.md
vtn-dev-prithipal b431d5c
Update README.md
vtn-dev-prithipal e68ec34
manuquentin requested changes updated
vtn-dev-prithipal af87fcf
Merge branch 'speakerOutputAndroid' of https://github.com/vtn-dev-pri…
vtn-dev-prithipal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -182,7 +182,14 @@ class RNCallKeep { | |
}; | ||
|
||
sendDTMF = (uuid, key) => RNCallKeepModule.sendDTMF(uuid, key); | ||
|
||
/** | ||
* @description when Phone call is active, Android control the audio service via connection service. so this function help to toggle the audio to Speaker or wired/ear-piece or vice-versa | ||
* @param {*} uuid | ||
* @param {*} routeSpeaker | ||
* @returns Audio route state of audio service | ||
*/ | ||
Comment on lines
+185
to
+190
This comment was marked as resolved.
Sorry, something went wrong. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated here b0a2fda please review |
||
toggleAudioRouteSpeaker = (uuid, routeSpeaker) => isIOS ? null : RNCallKeepModule.toggleAudioRouteSpeaker(uuid, routeSpeaker); | ||
|
||
checkIfBusy = () => | ||
isIOS ? RNCallKeepModule.checkIfBusy() : Promise.reject('RNCallKeep.checkIfBusy was called from unsupported OS'); | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.