-
Notifications
You must be signed in to change notification settings - Fork 459
Start a foreground service to be able to get audio on Android 11 bg #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This issue is only if you compile your application with the android 11 SDK. Are you agree @manuquentin? |
Oh this would make sense as to why my apps have all continued working @sboily (if thats the case) |
I made test and if i'm using my application with the SDK 29 on my android 11, i have no issue. But if i compile with the SDK 30, i reproduce this issue. |
I just tested this and reproduce the issue (without my patch applied) against both SDK 29 and SDK 30 on Android 11 (Pixel 4). |
Strange i don't reproduce that. My application works without any issues on pixel 3 and 5 with old SDK. |
Yes it is strange. I ditched my patch and ran my app with this branch and it works well! The only suggestion I'd add is the ability to specify a notification icon. |
Ok well, my mistake, i receive the audio, but nothing go out from the app! |
@grit96 have you tried with this PR? Is it ok for you? |
@sboily yes, tested the PR and it works. I think we need to use I also suggested adding the ability to set the notification icon. |
Thanks @grit96 I've added a check on the Android version and added the ability to set the smallIcon (not tested as I don't see the notification on Pixel 3...) |
Thanks @manuquentin, it works great! I guess the only thing left is to add docs for the icon. |
Refs #274
Thanks @grit96 for the patch !
Review/feedback are welcome for this one.