Avoid to check for reachability everytime we make a call #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we check for reachability.
Instead of setting
isReachableto false in theVoiceConnectionServiceconstructor, we set it to false in the module constructor.The
VoiceConnectionServiceconstructor is called each time a call is made, we don't have to reset theisReachableboolean, because when the JS bridge is reachable once in the module lifetime there is no need to check it again.This PR adds more logs and more information in logs.
This PR also fixes the
wakeUpApplicationwhich can be called twice when the reachability timeout is triggered.