Add setting for including calls in recents #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcorner am I right in saying this is enabled by default if you don't pass anything in as I see calls in recents on iOS - this just enables developers to support whether it should add them or not? |
|
Correct. |
|
I like this as a configurable option, great work @mcorner. |
|
@mcorner can you rebase off master to fix the conflicts so this can merge? |
|
@mcorner can you rebase? Then we can get this merged! |
|
ping @mcorner can you rebase this PR ? |
|
Sorry, we moved off of this project. Happy to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.