Skip to content

[Discuss] ios 13 handle voip incoming push notification #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

r0b0t3d
Copy link
Contributor

@r0b0t3d r0b0t3d commented Jul 29, 2019

With ios 13, apple has changed the flow we handle voip incoming push notification.

Important
On iOS 13.0 and later, incoming Voice over IP calls must be reported when they are received and before this method finishes execution using the CallKit framework, or the system will terminate your app. Repeatedly failing to report calls may prevent your app from receiving any more incoming call notifications.

https://developer.apple.com/documentation/pushkit/pkpushregistrydelegate/2875784-pushregistry

I update code to allow calling displayIncomingCall while handling voip push

- (void)pushRegistry:(PKPushRegistry *)registry didReceiveIncomingPushWithPayload:(PKPushPayload *)payload forType:(NSString *)type {
  // Process the received push
  [RNVoipPushNotificationManager didReceiveIncomingPushWithPayload:payload forType:(NSString *)type];
  [RNVoipPushNotificationManager didReceiveIncomingPushWithPayload:payload forType:(NSString *)type];
  [[RNCallKeep sharedInstance] displayIncomingCall:uuid handle:@"handle" handleType:@"generic" hasVideo:true localizedCallerName:@"caller name"];
}

If you have any idea how to solve this problem, please let me know

https://github.com/react-native-webrtc/react-native-voip-push-notification/issues/36

@r0b0t3d r0b0t3d closed this Aug 19, 2019
@manuquentin
Copy link
Contributor

Hi @r0b0t3d, why did you close this issue ? Isn't it relevant anymore ?

@r0b0t3d
Copy link
Contributor Author

r0b0t3d commented Aug 19, 2019

I need more time to test. Will open another PR if everything is ok

@redexp
Copy link

redexp commented Oct 9, 2019

@r0b0t3d I'm sorry, did you have any time to test this issue?

@r0b0t3d
Copy link
Contributor Author

r0b0t3d commented Oct 10, 2019

@redexp This issue has been merged on another PR. Please check #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants