forked from facebook/react-native-website
-
Notifications
You must be signed in to change notification settings - Fork 0
fix local build, basic theme overrides, header reorder, docusaurus bump #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview URL: https://deploy-preview-12--react-native-website-migration.netlify.app/ |
slorber
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Simek
added a commit
that referenced
this pull request
Oct 20, 2020
…mp (#12) * fix local build, basic theme overrides, header reorder, docusaurus bump * add navbar override group, update navbar typography * tweak version switcher and hr design * update page links style, fix text color issues * use docsVersionDropdown in navbar * fix validation warning * footer design tweaks, jsx as default prism language * add native code banner, fix version label design, update notes style * static dark navbar, color fix, docusaurus bump * tweak dark theme, fix page shrinking issue * navbar UI and positioning tweaks, update blog page * sidebar spacing, minor color tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
closeable
property@slorber I'm open to any suggestion because I do not have big experience with V2 yet. I tried to uses as many CSS variables and config setting as possible, before introducing any custom additions. 🙂
Docusaurus TODOs regarding this changes
style
to thenavbar
config to allow force alsways'dark'
style (similar implementation to the footer component)to
property in navbar items withitems
propertyhorizontal
orvertical
variables for both directions, example (there are more occurrences of this practice):ActivityIndicator
page container shrinks too much because page do not have any full-width sentences/paragraphs.Preview