Skip to content

Set up a minimal D2 site #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Sep 2, 2020
Merged

Set up a minimal D2 site #3

merged 25 commits into from
Sep 2, 2020

Conversation

teikjun
Copy link
Member

@teikjun teikjun commented Aug 28, 2020

Summary

This PR sets up a minimal D2 site.

With reference to docs/v2-migration branch:

  • this PR cherry-picks up until the commit 6d1057f: fix errors in docs.
  • this PR excludes commits for CSS file migration (a663bc7 and 684e70b) to keep the PR minimal.

Log

  • Run migration CLI
  • Remove unused versions
  • remove from /versioned_docs, /versioned_sidebar, versions.json, docusaurus.config.js
  • Fix build errors from all versioned_docs and current docs
  • close all unclosed tags, remove invalid tags
  • for any invalid JSX outside codeblocks, enclose them in codeblocks
  • use MDX compatible syntax: change class to className, change style="..." to style={{...}}.
  • Fix other build errors
  • Fix url-loader issue
  • Fix errors in blog
  • Migrate navbar and footer items

Suggestions for next PRs

  • migrate CSS files (remember to include a663bc7 and 684e70b)
  • migrate pages
  • replace snack player remarkable plugin with remark plugin.
  • add tabs

The next PRs should be much smaller

Remarks

The bug that results in disappearing doc content is already present at this stage.

@teikjun teikjun mentioned this pull request Aug 28, 2020
5 tasks
@teikjun teikjun requested review from darshkpatel and slorber August 28, 2020 14:15
@teikjun
Copy link
Member Author

teikjun commented Aug 28, 2020

made the requested changes from #2. opened the PR against main because the bot will reset the changes in master: #2 (comment)

Copy link
Member

@darshkpatel darshkpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slorber slorber merged commit f74ba52 into main Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants