-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
fix: disable screen readers on stacked transparentModal screens for improved accessibility #12541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…improved accessibility
Hey @theonetheycallneo! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the PR. This is part of a larger effort to replace all a11y related props with If you'd like to take over that PR, then feel free. The biggest part left is to test the changes to see if it works, and rebase the PR against latest changes. |
Motivation
Web screen readers can see the components on the previous underlying screens.
I noticed we already do this for iOS and Android via:
So, simply adding the 3rd aria-hidden to improve web acessibility.
Test plan
presentation: transparentModal
Related:
necolas/react-native-web#2773