fix: remove calls to removed Keyboard.removeListener in useIsKeyboardShown #9457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-navigation-example ready! Built with commit 86ce9fb https://deploy-preview-9457--react-navigation-example.netlify.app |
|
The Expo app for the example from this branch is ready! expo.io/@react-navigation/react-navigation-example?release-channel=pr-9457 |
satya164
reviewed
Apr 3, 2021
|
Thanks |
jbaudanza
pushed a commit
to Hilokal/react-navigation
that referenced
this pull request
Sep 14, 2021
|
Hey guys, |
|
Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro. |
chrisbobbe
pushed a commit
to chrisbobbe/react-navigation
that referenced
this pull request
Apr 27, 2022
chrisbobbe
pushed a commit
to chrisbobbe/react-navigation
that referenced
this pull request
Apr 28, 2022
…Shown (react-navigation#9457) chris: this is a cherry-pick of d87857e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyboard.removeEventListener was restored in facebook/react-native@035718b but not Keyboard.removeListener. In this case we can use the subscription object returned from addListener. The addListener method always returned a subscription object so no need to check if the return value is an object (like in other cases of addEventListener methods).